wnagrodzki/iNapi
1
0
Fork 0
mirror of https://github.com/wnagrodzki/iNapi.git synced 2025-04-05 11:51:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Code cleanup: accessors are not used in inits and deallocs

Browse source
This commit is contained in:
Wojciech Nagrodzki 2012-08-04 11:02:30 +02:00
parent 16509b79cf
commit 5968766c17
Signed by: wnagrodzki
GPG key ID: E9D0EB0302264569
3 changed files with 12 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
iNapi/Classes/Helpers/INPMovieFilter.m
View file

@ -21,13 +21,11 @@
@implementation INPMovieFilter
@synthesize fileManager;
- (id)init
{
self = [super init];
if (self) {
self.fileManager = [NSFileManager defaultManager];
_fileManager = [NSFileManager defaultManager];
}
return self;
}
@ -40,7 +38,7 @@
BOOL isDirectory;
for (NSString * path in filePaths) {
[fileManager fileExistsAtPath:path isDirectory:&isDirectory];
[self.fileManager fileExistsAtPath:path isDirectory:&isDirectory];
if (isDirectory) {
NSArray * moviePathsAtDirectory = [self moviePathsAtDirectory:path];
@ -80,14 +78,14 @@
{
NSMutableArray * movies = [NSMutableArray array];
NSDirectoryEnumerator* enumerator = [fileManager enumeratorAtPath:directoryPath];
NSDirectoryEnumerator* enumerator = [self.fileManager enumeratorAtPath:directoryPath];
BOOL isDirectory;
NSString * iPath = nil;
NSString* completeIPath = nil;
while (iPath = [enumerator nextObject]) {
completeIPath = [[NSString stringWithString:directoryPath] stringByAppendingPathComponent:iPath];
[fileManager fileExistsAtPath:completeIPath isDirectory: &isDirectory];
[self.fileManager fileExistsAtPath:completeIPath isDirectory: &isDirectory];
if (!isDirectory)
if ([self fileConformsToMovieUTI:completeIPath])

13
iNapi/Classes/Helpers/INSubtitleDownloader.m
View file

@ -19,11 +19,6 @@
@implementation INSubtitleDownloader
@synthesize delegate;
// Private
@synthesize downloadQueue;
@synthesize fileManager;
+ (INSubtitleDownloader *)sharedDownloader
{
__strong static id _sharedObject = nil;
@ -38,16 +33,16 @@
{
self = [super init];
if (self) {
self.downloadQueue = dispatch_queue_create("com.izydor86.inapi.downloadSubtitles", DISPATCH_QUEUE_SERIAL);
self.fileManager = [NSFileManager defaultManager];
_downloadQueue = dispatch_queue_create("com.izydor86.inapi.downloadSubtitles", DISPATCH_QUEUE_SERIAL);
_fileManager = [NSFileManager defaultManager];
}
return self;
}
- (void)dealloc
{
dispatch_release(downloadQueue);
self.downloadQueue = NULL;
dispatch_release(_downloadQueue);
_downloadQueue = NULL;
}
#pragma mark - Interface

13
iNapi/Classes/Models/INDownloadResult.m
View file

@ -19,28 +19,23 @@
@implementation INDownloadResult
@synthesize movieFileName;
@synthesize downloadResultImage;
// Private
@synthesize downloadedSubtitlesURL;
- (id)initWithDownloadedSubtitlesURL:(NSURL *)aDownloadedSubtitlesURL error:(NSError *)error
{
self = [super init];
if (self) {
self.downloadedSubtitlesURL = aDownloadedSubtitlesURL;
_downloadedSubtitlesURL = aDownloadedSubtitlesURL;
if (error == nil) {
self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusSucceeded"];
_downloadResultImage = [NSImage imageNamed:@"DownloadStatusSucceeded"];
return self;
}
if ([error.domain isEqualToString:@"com.izydor86.iNapi"] && error.code == 404) {
self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusNotFound"];
_downloadResultImage = [NSImage imageNamed:@"DownloadStatusNotFound"];
return self;
}
self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusFailed"];
_downloadResultImage = [NSImage imageNamed:@"DownloadStatusFailed"];
}
return self;
}