From 5968766c17acfaa2e1114fa69484fb98952b4eea Mon Sep 17 00:00:00 2001
From: Wojciech Nagrodzki <278594+wnagrodzki@users.noreply.github.com>
Date: Sat, 4 Aug 2012 11:02:30 +0200
Subject: [PATCH] Code cleanup: accessors are not used in inits and deallocs

---
 iNapi/Classes/Helpers/INPMovieFilter.m       | 10 ++++------
 iNapi/Classes/Helpers/INSubtitleDownloader.m | 13 ++++---------
 iNapi/Classes/Models/INDownloadResult.m      | 13 ++++---------
 3 files changed, 12 insertions(+), 24 deletions(-)

diff --git a/iNapi/Classes/Helpers/INPMovieFilter.m b/iNapi/Classes/Helpers/INPMovieFilter.m
index 82630d0..ab49f13 100644
--- a/iNapi/Classes/Helpers/INPMovieFilter.m
+++ b/iNapi/Classes/Helpers/INPMovieFilter.m
@@ -21,13 +21,11 @@
 
 @implementation INPMovieFilter
 
-@synthesize fileManager;
-
 - (id)init
 {
     self = [super init];
     if (self) {
-        self.fileManager = [NSFileManager defaultManager];
+        _fileManager = [NSFileManager defaultManager];
     }
     return self;
 }
@@ -40,7 +38,7 @@
 	
 	BOOL isDirectory;
 	for (NSString * path in filePaths) {
-		[fileManager fileExistsAtPath:path isDirectory:&isDirectory];
+		[self.fileManager fileExistsAtPath:path isDirectory:&isDirectory];
 		
 		if (isDirectory) {
 			NSArray * moviePathsAtDirectory = [self moviePathsAtDirectory:path];
@@ -80,14 +78,14 @@
 {
 	NSMutableArray * movies = [NSMutableArray array];
 	
-	NSDirectoryEnumerator* enumerator = [fileManager enumeratorAtPath:directoryPath];
+	NSDirectoryEnumerator* enumerator = [self.fileManager enumeratorAtPath:directoryPath];
 	BOOL isDirectory;
 	NSString * iPath = nil;
 	NSString* completeIPath = nil;
 	
 	while (iPath = [enumerator nextObject]) {
 		completeIPath = [[NSString stringWithString:directoryPath] stringByAppendingPathComponent:iPath];
-		[fileManager fileExistsAtPath:completeIPath isDirectory: &isDirectory];
+		[self.fileManager fileExistsAtPath:completeIPath isDirectory: &isDirectory];
 		
 		if (!isDirectory)
 			if ([self fileConformsToMovieUTI:completeIPath])
diff --git a/iNapi/Classes/Helpers/INSubtitleDownloader.m b/iNapi/Classes/Helpers/INSubtitleDownloader.m
index abc7d18..8cfcb14 100644
--- a/iNapi/Classes/Helpers/INSubtitleDownloader.m
+++ b/iNapi/Classes/Helpers/INSubtitleDownloader.m
@@ -19,11 +19,6 @@
 
 @implementation INSubtitleDownloader
 
-@synthesize delegate;
-// Private
-@synthesize downloadQueue;
-@synthesize fileManager;
-
 + (INSubtitleDownloader *)sharedDownloader
 {
     __strong static id _sharedObject = nil;
@@ -38,16 +33,16 @@
 {
     self = [super init];
     if (self) {
-        self.downloadQueue = dispatch_queue_create("com.izydor86.inapi.downloadSubtitles", DISPATCH_QUEUE_SERIAL);
-        self.fileManager = [NSFileManager defaultManager];
+        _downloadQueue = dispatch_queue_create("com.izydor86.inapi.downloadSubtitles", DISPATCH_QUEUE_SERIAL);
+        _fileManager = [NSFileManager defaultManager];
     }
     return self;
 }
 
 - (void)dealloc
 {
-    dispatch_release(downloadQueue);
-    self.downloadQueue = NULL;
+    dispatch_release(_downloadQueue);
+    _downloadQueue = NULL;
 }
 
 #pragma mark - Interface
diff --git a/iNapi/Classes/Models/INDownloadResult.m b/iNapi/Classes/Models/INDownloadResult.m
index c683843..87173e3 100644
--- a/iNapi/Classes/Models/INDownloadResult.m
+++ b/iNapi/Classes/Models/INDownloadResult.m
@@ -19,28 +19,23 @@
 
 @implementation INDownloadResult
 
-@synthesize movieFileName;
-@synthesize downloadResultImage;
-// Private
-@synthesize downloadedSubtitlesURL;
-
 - (id)initWithDownloadedSubtitlesURL:(NSURL *)aDownloadedSubtitlesURL error:(NSError *)error
 {
     self = [super init];
     if (self) {
-        self.downloadedSubtitlesURL = aDownloadedSubtitlesURL;
+        _downloadedSubtitlesURL = aDownloadedSubtitlesURL;
         
         if (error == nil) {
-            self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusSucceeded"];
+            _downloadResultImage = [NSImage imageNamed:@"DownloadStatusSucceeded"];
             return self;
         }
         
         if ([error.domain isEqualToString:@"com.izydor86.iNapi"] && error.code == 404) {
-            self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusNotFound"];
+            _downloadResultImage = [NSImage imageNamed:@"DownloadStatusNotFound"];
             return self;
         }
         
-        self.downloadResultImage = [NSImage imageNamed:@"DownloadStatusFailed"];
+        _downloadResultImage = [NSImage imageNamed:@"DownloadStatusFailed"];
     }
     return self;
 }